Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database/gdb): when constructing query param, gdb.Row value not directly write to Buffer #3718

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

cyjaysong
Copy link
Contributor

@cyjaysong cyjaysong commented Jul 31, 2024

fix #3649 when constructing query param, gdb.Row value not directly write to Buffer

@cyjaysong cyjaysong changed the title fix(database/gdb): fix#3649 when constructing query param, gdb.Row value not directly write to Buffer fix(database/gdb): fix #3649 when constructing query param, gdb.Row value not directly write to Buffer Jul 31, 2024
@cyjaysong
Copy link
Contributor Author

@gqcn @hailaz

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@gqcn @hailaz

@hailaz
Copy link
Member

hailaz commented Jul 31, 2024

这个问题是解决,但不确定有没其他情况需要用到原来的那个逻辑分支。 @gqcn 看看

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This problem is solved, but I am not sure if there are other situations where the original logical branch needs to be used. @gqcn take a look

Copy link

sonarcloud bot commented Aug 1, 2024

@cyjaysong cyjaysong requested a review from gqcn August 1, 2024 14:44
@gqcn gqcn merged commit 6e5ce98 into gogf:master Aug 14, 2024
24 checks passed
@cyjaysong cyjaysong deleted the fix/3649 branch August 19, 2024 10:29
@gqcn gqcn changed the title fix(database/gdb): fix #3649 when constructing query param, gdb.Row value not directly write to Buffer fix(database/gdb): when constructing query param, gdb.Row value not directly write to Buffer Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

database/gdb: Using gdb.Raw conditions in where when querying does not meet expectations
4 participants