Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial #3684

Merged
merged 8 commits into from
Sep 30, 2024
Merged

feat(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial #3684

merged 8 commits into from
Sep 30, 2024

Conversation

oldme-git
Copy link
Member

@oldme-git oldme-git commented Jul 17, 2024 •
edited
Loading

Dear reviewer:
升级依赖至 Go 1.21
在 rpc 的新版本中已经弃用 grpc.Dial:
https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md
另外，减少了一些代码的缩进

@oldme-git oldme-git marked this pull request as draft July 17, 2024 06:01
@oldme-git oldme-git changed the title refactor(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial build(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial Jul 17, 2024
@gqcn
Copy link
Member

gqcn commented Jul 17, 2024 •
edited
Loading

@oldme-git 需要等待#3688 合并后更新该pr，同样放到v2.8.0版本合并发布。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@oldme-git needs to wait for #3688 to be merged and then update the pr, and also put it into the v2.8.0 version for merge and release.

@gqcn gqcn added this to the v2.8.0 milestone Jul 17, 2024
@gqcn
Copy link
Member

gqcn commented Sep 28, 2024

@oldme-git

@oldme-git 需要等待#3688 合并后更新该pr，同样放到v2.8.0版本合并发布。

@oldme-git #3688 已经合并，可更新该PR了。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@oldme-git

@oldme-git needs to wait for #3688 to be merged and update the pr, and also put it into the v2.8.0 version for merge and release.

@oldme-git #3688 has been merged and the PR can be updated.

@oldme-git
Merge remote-tracking branch 'gf/master' into build/grpcx
fb80488 
# Conflicts:
#	contrib/rpc/grpcx/go.mod
#	contrib/rpc/grpcx/go.sum
@oldme-git
up
f280d04
@oldme-git oldme-git marked this pull request as ready for review September 28, 2024 16:02
@oldme-git
Copy link
Member Author

@oldme-git

@oldme-git 需要等待#3688 合并后更新该pr，同样放到v2.8.0版本合并发布。

@oldme-git #3688 已经合并，可更新该PR了。

ok

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@oldme-git

@oldme-git needs to wait for #3688 to be merged and update the pr, and also put it into the v2.8.0 version for merge and release.

@oldme-git #3688 has been merged and the PR can be updated.

OK

@gqcn gqcn changed the title build(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial feat(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial Sep 30, 2024
@gqcn gqcn merged commit d4fa2c8 into gogf:master Sep 30, 2024
20 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oldme-git @gqcn @Issues-translate-bot