Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(database/gdb): remove duplicated SQL records in tracing events #3659

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

houseme
Copy link
Member

@houseme houseme commented Jun 22, 2024

#3658

改为统一的官方协议,以及去除重复记录,减少trace的存储大小

@houseme houseme requested review from gqcn and hailaz June 22, 2024 04:41
@gqcn
Copy link
Member

gqcn commented Jun 24, 2024

@houseme 这个SQL语句去除后就没了哦,哪里有重复的SQL提交呢?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme This SQL statement will disappear after being removed. Where are the duplicate SQL submissions?

@houseme
Copy link
Member Author

houseme commented Jun 25, 2024

@houseme 这个SQL语句去除后就没了哦,哪里有重复的SQL提交呢?

semconv.DBStatement(sql.Format) 第59行

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme This SQL statement will disappear after being removed. Where are the duplicate SQL submissions?

semconv.DBStatement(sql.Format) line 59

@gqcn gqcn changed the title feat: improve duplicate SQL records in the database database/gdb: remove duplicate SQL records in tracing events Jun 25, 2024
@gqcn gqcn changed the title database/gdb: remove duplicate SQL records in tracing events database/gdb: remove duplicated SQL records in tracing events Jun 25, 2024
@gqcn gqcn merged commit f8272bc into master Jun 25, 2024
46 checks passed
@gqcn gqcn deleted the feature/improve-db-trace branch June 25, 2024 13:11
@gqcn gqcn changed the title database/gdb: remove duplicated SQL records in tracing events refactor(database/gdb): remove duplicated SQL records in tracing events Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants