Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metric feature support in goframe #3138

Merged
merged 67 commits into from
Mar 24, 2024
Merged

feat: add metric feature support in goframe #3138

merged 67 commits into from
Mar 24, 2024

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Nov 8, 2023

  1. add new package gmetric, which provides asbstract metric interface definitions
  2. add new cotribution package contrib/metric/otelmetric , which implements the interfaces of package gmetric

@gqcn gqcn added the wip label Nov 10, 2023
@houseme
Copy link
Member

houseme commented Nov 13, 2023

metric 和 trace 可以整合到一起初始化吗?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Can metric and trace be integrated and initialized together?

@gqcn
Copy link
Member Author

gqcn commented Nov 13, 2023

metric 和 trace 可以整合到一起初始化吗?

我看otel官方的示例也是分开初始化的,我们也不用整合吧

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Can metric and trace be integrated and initialized together?

I see that the official examples from Hotel are also initialized separately, so we don’t need to integrate them.

@gqcn gqcn removed the wip label Mar 22, 2024
@gqcn gqcn merged commit 8669512 into master Mar 24, 2024
48 checks passed
@gqcn gqcn deleted the feature/metric branch March 24, 2024 13:18
oldme-git pushed a commit to oldme-git/gf that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants