Skip to content

Get UI working with ephemeral chain #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Conversation

brandonfancher
Copy link
Collaborator

@brandonfancher brandonfancher commented Nov 18, 2021

Refactoring areas of UI dependence on AtomicHub APIs for member data to instead use subchain. For example, the account profile component in the nav bars, My Delegation page, and ongoing election UI was broken when running on the ephemeral chain. This fixes that.

While I need to finish testing a full election before I know everything is working properly, this does represent important progress. So I'll go ahead and submit this for review.

Once UI-working-with-ephemeral-chain baseline is met, we can get into deeper refactoring.

@brandonfancher brandonfancher marked this pull request as ready for review November 18, 2021 23:39
@brandonfancher brandonfancher temporarily deployed to e2e_tests November 18, 2021 23:39 Inactive
@brandonfancher
Copy link
Collaborator Author

By the way, I LOVE ephemeral chain. So much easier (once you get the hang of it). I even added it as a custom network in bloks.io and Anchor so I can use those tools too. 💯

Copy link
Collaborator

@sparkplug0025 sparkplug0025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: amazing to see things getting simpler!

By the way, I LOVE ephemeral chain. So much easier (once you get the hang of it). I even added it as a custom network in bloks.io and Anchor so I can use those tools too. 💯

We need to productize it correctly and sell the idea in a nice way: no-brainer, small demoable flow in a landing page/hotsite!

Eg: I dig https://graphql.org/ one! -- the explanation through animations!

@brandonfancher brandonfancher merged commit d44b1c6 into main Nov 19, 2021
@brandonfancher brandonfancher deleted the bf/elections-queries branch November 19, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants