Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug related to withdrawal enhancements #603

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix bug related to withdrawal enhancements #603

merged 1 commit into from
Nov 11, 2021

Conversation

brandonfancher
Copy link
Collaborator

@brandonfancher brandonfancher commented Nov 11, 2021 •
edited
Loading

  1. Delegate successfully withdraws funds. (The first time they do this, all of their available distributions are moved from the distribution accounts to their personal Eden account.)
  2. Delegate tries to withdraw again, but it fails. This is because we're trying to claim distributions with 0 balances...again.)

This filters those 0-amount fundtransfer actions out.

@brandonfancher brandonfancher temporarily deployed to e2e_tests November 11, 2021 16:04 Inactive
@brandonfancher brandonfancher merged commit 217d9a6 into main Nov 11, 2021
@brandonfancher brandonfancher deleted the bf/withdraw-fix branch November 11, 2021 16:13
@brandonfancher brandonfancher mentioned this pull request Nov 11, 2021
Merged
@brandonfancher brandonfancher linked an issue Nov 11, 2021 that may be closed by this pull request
eden: [funds] enhanced withdraw #594
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbfleming tbfleming tbfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eden: [funds] enhanced withdraw
2 participants
@brandonfancher @tbfleming