Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw Options #597

Merged
merged 13 commits into from
Nov 11, 2021
Merged

Withdraw Options #597

merged 13 commits into from
Nov 11, 2021

Conversation

brandonfancher
Copy link
Collaborator

@brandonfancher brandonfancher commented Nov 2, 2021 •
edited
Loading

In this PR

Enables a user to specify a withdraw-to account name, amount and memo.

Remaining

  • Refactor into appropriate components
  • Subchain refactors
  • Run it through the tests
  • Make sure new env vars get where they need to go (before merge)

@brandonfancher brandonfancher temporarily deployed to e2e_tests November 3, 2021 05:12 Inactive
@brandonfancher brandonfancher marked this pull request as ready for review November 4, 2021 23:02
@brandonfancher brandonfancher temporarily deployed to e2e_tests November 4, 2021 23:08 Inactive
sparkplug0025
sparkplug0025 approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@sparkplug0025 sparkplug0025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great job on this PR!

I gave some suggestions which are not blockers for merging this one!

packages/webapp/src/members/components/withdraw-funds/withdraw-modal-step-form.tsx Show resolved Hide resolved
packages/webapp/src/members/transactions.ts Show resolved Hide resolved
packages/webapp/.env Show resolved Hide resolved
packages/webapp/src/members/components/withdraw-funds/withdraw-modal-step-form.tsx Outdated Show resolved Hide resolved
packages/webapp/src/members/components/withdraw-funds/withdraw-modal-step-form.tsx Outdated Show resolved Hide resolved
@brandonfancher brandonfancher temporarily deployed to e2e_tests November 10, 2021 23:45 Inactive
@brandonfancher brandonfancher temporarily deployed to e2e_tests November 11, 2021 14:44 Inactive
@brandonfancher brandonfancher merged commit 50d5de1 into main Nov 11, 2021
@brandonfancher brandonfancher deleted the bf/withdraw-enhancements branch November 11, 2021 14:55
@brandonfancher brandonfancher mentioned this pull request Nov 11, 2021
Merged
@brandonfancher brandonfancher linked an issue Nov 11, 2021 that may be closed by this pull request
eden: [funds] enhanced withdraw #594
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkplug0025 sparkplug0025 sparkplug0025 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eden: [funds] enhanced withdraw
2 participants
@brandonfancher @sparkplug0025