Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom favicon.ico #571

Merged
merged 4 commits into from
May 6, 2024
Merged

Add support for custom favicon.ico #571

merged 4 commits into from
May 6, 2024

Conversation

Umang01-hash
Copy link
Member

@Umang01-hash Umang01-hash commented May 6, 2024 •
edited
Loading

Pull Request Template

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@srijan-27 srijan-27 merged commit dddf147 into development May 6, 2024
13 checks passed
@srijan-27 srijan-27 deleted the fe/custom_favicon_support branch May 6, 2024 12:34
@srijan-27 srijan-27 mentioned this pull request May 7, 2024
Closed
srijan-27 pushed a commit that referenced this pull request May 10, 2024
@Umang01-hash @srijan-27
Add support for custom favicon.ico (#571)
a68c1a7
@srijan-27 srijan-27 mentioned this pull request May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipul-rawat vipul-rawat vipul-rawat approved these changes

@srijan-27 srijan-27 srijan-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Umang01-hash @vipul-rawat @srijan-27