Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: [issue 1078] handled panic in redis ping #1085

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

vigneshp91
Copy link
Contributor

@vigneshp91 vigneshp91 commented Oct 7, 2024

Pull Request Template

Fixes #1078
Description:
Handled the panic when calling redis ping function when the connection is not available.

@vigneshp91 vigneshp91 changed the title handled panic in redis ping fixes: [issue 1078] handled panic in redis ping Oct 7, 2024
Copy link
Contributor

@Umang01-hash Umang01-hash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test Test_newContainerDBInitializationFail is failing in your PR as now the redis client is not nil. Please update the test also.

Also there is a linter error in code:
Screenshot 2024-10-08 at 3 18 12 PM

Please resolve that too.

@Umang01-hash Umang01-hash merged commit 6d48191 into gofr-dev:development Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping Function in Redis panics when called without being connected to redis in application
3 participants