WIP feat(fqdn): review fqdn setup #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13759528700Details
💛 - Coveralls |
ivankatliarchuk
pushed a commit
that referenced
this pull request
Apr 16, 2025
# This is the 1st commit message: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #2: chore(deps): bump renovatebot/github-action Bumps the dev-dependencies group with 1 update: [renovatebot/github-action](https://github.com/renovatebot/github-action). Updates `renovatebot/github-action` from 41.0.14 to 41.0.16 - [Release notes](https://github.com/renovatebot/github-action/releases) - [Changelog](https://github.com/renovatebot/github-action/blob/main/CHANGELOG.md) - [Commits](renovatebot/github-action@v41.0.14...v41.0.16) --- updated-dependencies: - dependency-name: renovatebot/github-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> # This is the commit message #3: feat(chart): Update image to v0.16.1 Signed-off-by: Steve Hipwell <[email protected]> # This is the commit message #4: chore(deps): bump renovatebot/github-action Bumps the dev-dependencies group with 1 update: [renovatebot/github-action](https://github.com/renovatebot/github-action). Updates `renovatebot/github-action` from 41.0.16 to 41.0.17 - [Release notes](https://github.com/renovatebot/github-action/releases) - [Changelog](https://github.com/renovatebot/github-action/blob/main/CHANGELOG.md) - [Commits](renovatebot/github-action@v41.0.16...v41.0.17) --- updated-dependencies: - dependency-name: renovatebot/github-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> # This is the commit message #5: feat: IDNA awareness in the zone finder (kubernetes-sigs#5147) * feat: IDNA awareness in the zone finder * feat: update zonefinder unit tests * chore: add warning log and respective test # This is the commit message #6: feat(banner): standardize user agent and output (kubernetes-sigs#5154) * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * feat(banner): standartise user agent and output banner Signed-off-by: ivan katliarchuk <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #7: fix(cloudflare): custom hostnames edge-cases causing duplicates (kubernetes-sigs#5183) * fix(cloudflare): custom hostnames edge-cases causing duplicates * syntax/style * Use %q log fmt for cloudflare provider code * move custom hostnames related submitChanges() implementation to a separate method submitCustomHostnameChanges(); extend truncated logging * use maps for DNS records getRecordID() and custom hostnames getCustomHostname() for faster lookups * types for records/custom hostnames maps * tidy up using underlying maps for dns records and custom hostnames * style/naming * fix private names * combine unnecessarily separated conditions # This is the commit message #8: fix: correct route53 iam # This is the commit message #9: chore(deps): bump the dev-dependencies group across 1 directory with 20 updates Bumps the dev-dependencies group with 16 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) | `1.17.0` | `1.17.1` | | [github.com/IBM-Cloud/ibm-cloud-cli-sdk](https://github.com/IBM-Cloud/ibm-cloud-cli-sdk) | `1.6.2` | `1.7.0` | | [github.com/IBM/go-sdk-core/v5](https://github.com/IBM/go-sdk-core) | `5.18.5` | `5.19.0` | | [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.63.92` | `1.63.100` | | [github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue](https://github.com/aws/aws-sdk-go-v2) | `1.18.7` | `1.18.8` | | [github.com/aws/aws-sdk-go-v2/service/route53](https://github.com/aws/aws-sdk-go-v2) | `1.49.1` | `1.50.0` | | [github.com/civo/civogo](https://github.com/civo/civogo) | `0.3.94` | `0.3.95` | | [github.com/digitalocean/godo](https://github.com/digitalocean/godo) | `1.138.0` | `1.141.0` | | [github.com/miekg/dns](https://github.com/miekg/dns) | `1.1.63` | `1.1.64` | | [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.85.0` | `65.87.0` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1115` | `1.0.1129` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1115` | `1.0.1128` | | [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) | `3.5.19` | `3.5.20` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.223.0` | `0.227.0` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.2` | `0.32.3` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.2` | `0.32.3` | Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.17.0 to 1.17.1 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.17.0...sdk/azcore/v1.17.1) Updates `github.com/IBM-Cloud/ibm-cloud-cli-sdk` from 1.6.2 to 1.7.0 - [Release notes](https://github.com/IBM-Cloud/ibm-cloud-cli-sdk/releases) - [Commits](IBM-Cloud/ibm-cloud-cli-sdk@v1.6.2...v1.7.0) Updates `github.com/IBM/go-sdk-core/v5` from 5.18.5 to 5.19.0 - [Release notes](https://github.com/IBM/go-sdk-core/releases) - [Changelog](https://github.com/IBM/go-sdk-core/blob/main/CHANGELOG.md) - [Commits](IBM/go-sdk-core@v5.18.5...v5.19.0) Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.63.92 to 1.63.100 - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.92...v1.63.100) Updates `github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue` from 1.18.7 to 1.18.8 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.18.7...config/v1.18.8) Updates `github.com/aws/aws-sdk-go-v2/service/dynamodb` from 1.41.1 to 1.42.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ecr/v1.41.1...service/s3/v1.42.0) Updates `github.com/aws/aws-sdk-go-v2/service/route53` from 1.49.1 to 1.50.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ssm/v1.49.1...service/s3/v1.50.0) Updates `github.com/civo/civogo` from 0.3.94 to 0.3.95 - [Release notes](https://github.com/civo/civogo/releases) - [Changelog](https://github.com/civo/civogo/blob/master/changelog.yml) - [Commits](civo/civogo@v0.3.94...v0.3.95) Updates `github.com/digitalocean/godo` from 1.138.0 to 1.141.0 - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](digitalocean/godo@v1.138.0...v1.141.0) Updates `github.com/miekg/dns` from 1.1.63 to 1.1.64 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.63...v1.1.64) Updates `github.com/oracle/oci-go-sdk/v65` from 65.85.0 to 65.87.0 - [Release notes](https://github.com/oracle/oci-go-sdk/releases) - [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md) - [Commits](oracle/oci-go-sdk@v65.85.0...v65.87.0) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.1115 to 1.0.1129 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1115...v1.0.1129) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.1115 to 1.0.1128 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1115...v1.0.1128) Updates `go.etcd.io/etcd/client/v3` from 3.5.19 to 3.5.20 - [Release notes](https://github.com/etcd-io/etcd/releases) - [Commits](etcd-io/etcd@v3.5.19...v3.5.20) Updates `golang.org/x/net` from 0.36.0 to 0.37.0 - [Commits](golang/net@v0.36.0...v0.37.0) Updates `golang.org/x/text` from 0.22.0 to 0.23.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.22.0...v0.23.0) Updates `google.golang.org/api` from 0.223.0 to 0.227.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.223.0...v0.227.0) Updates `k8s.io/api` from 0.32.2 to 0.32.3 - [Commits](kubernetes/api@v0.32.2...v0.32.3) Updates `k8s.io/apimachinery` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apimachinery@v0.32.2...v0.32.3) Updates `k8s.io/client-go` from 0.32.2 to 0.32.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.2...v0.32.3) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/IBM-Cloud/ibm-cloud-cli-sdk dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/IBM/go-sdk-core/v5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/dynamodb dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/route53 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/civo/civogo dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/digitalocean/godo dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/miekg/dns dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/oracle/oci-go-sdk/v65 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> # This is the commit message #10: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #11: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #12: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #13: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #14: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> # This is the commit message #15: chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #ISSUE
Checklist