feat(source/istio): fix gateway→service selector matching with per-entry indexer#68
Open
ivankatliarchuk wants to merge 1 commit into
Open
feat(source/istio): fix gateway→service selector matching with per-entry indexer#68ivankatliarchuk wants to merge 1 commit into
ivankatliarchuk wants to merge 1 commit into
Conversation
…try indexer Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Pull Request Test Coverage Report for Build 23384706663Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The Istio gateway source resolves DNS targets by matching gateway.spec.selector against service.spec.selector using subset semantics — a gateway with {istio:
ingressgateway} must match a service whose selector is {istio: ingressgateway, release: istio}. PR kubernetes-sigs#5708 attempted to speed this up with an index but keyed services by a
hash of their full selector, breaking the subset match (only exact matches worked). The PR was closed as buggy.
https://github.com/kubernetes-sigs/external-dns/pull/5708/changes#diff-6895e4e602c3815e3e3b67fa2cb633b9b2c4b83bb22ef9caebf650a5f9e4d0ba
What:
lookups
multi-entry selectors
More