WIP Add sandbox name validation with DNS label compliance - #76
Draft
dbmikus wants to merge 1 commit into
Draft
Conversation
Restrict sandbox names to lowercase letters, numbers, and hyphens (max 63 chars, no leading/trailing/consecutive hyphens). This ensures names are valid DNS labels for domain name compatibility. https://claude.ai/code/session_01TND4LDP6AZGUbi92edwe14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive validation for sandbox names to ensure they comply with DNS label requirements and maintain consistency across the system.
Key Changes
Added
ValidateName()function ininternal/sandbox/names.gothat validates sandbox names against the following rules:Added regex pattern validation using
namePatternto enforce the allowed character set and hyphen placement rulesAdded
MaxNameLengthconstant set to 63 to match DNS label specificationsIntegrated validation into
CreateSandbox()inpkg/amika/service.goto validate user-provided sandbox names before creationAdded comprehensive test coverage in
internal/sandbox/names_test.go:TestValidateName()validates both valid and invalid name formatsTestGenerateNameIsValid()ensures auto-generated names always pass validationImplementation Details
^[a-z0-9]+(-[a-z0-9]+)*$to ensure hyphens only appear between alphanumeric segmentsErrInvalidArgumenton failurehttps://claude.ai/code/session_01TND4LDP6AZGUbi92edwe14