Add sandbox codev2 editor support - #325
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28d923c8ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sandboxCodeCmd.Flags().String("editor", "cursor", "Editor or agent to open: \"cursor\", \"claude\", or \"codex\"") | ||
| sandboxCodeCmd.Flags().String("path", "", "Override the remote path to open (absolute, or relative to the sandbox workspace root)") | ||
| sandboxCodeV2Cmd.Flags().String("editor", "cursor", "Editor or agent to open: \"cursor\", \"claude\", or \"codex\"") | ||
| sandboxCodeV2Cmd.Flags().String("path", "", "Override the remote path to open (absolute, or relative to the sandbox workspace root)") |
There was a problem hiding this comment.
When a user passes codev2 --path foo, this flag promises a path relative to the sandbox workspace root, but resolveRemoteWorkspacePath resolves it to /home/amika/foo rather than /home/amika/workspace/foo. This can open the wrong or nonexistent directory; either resolve relative values beneath the workspace directory or describe them as relative to the sandbox home.
AGENTS.md reference: AGENTS.md:L136-L136
Useful? React with 👍 / 👎.
dbmikus
added a commit
that referenced
this pull request
Aug 10, 2026
Release amika@v0.14.0. Changes since amika@v0.13.0: Direct (no-relay) SSH transport: - Define and tighten the no-relay SSH contracts and vertical-slice spec (fc01f30, 650b433, dac6b6d) - Implement the local no-relay SSH path and fix its runtime lifecycle (d4bb156, 05c6df1) - Add `amika scpv2` over the direct WebSocket transport (9dccbfd) - Bind the managed sshd to a reserved loopback port (2e90dc6) - Scope v2 SSH session config per control plane (c7063c7) - Resolve SSH relay review annotations and document the connect-token round trip (#322) SSH key handling: - Harden authorized key handling and close an ownership race (b565213, f448546, 3fde13c) - Add an amikad authorized-keys clear subcommand (0e2fa59) - Add the amika secret ssh-key command group (#324) Sandbox images: - Build and package amikad into the base images (6279f28, f336617) - Repin the reviewed amikad source as fixes landed (862cbbd, 4777f5c, f864496, a6a4c04) - Add sandbox codev2 editor support (#325) Testing and CI: - Test snapshot scrubbing end to end (#323) - Publish linux-vm Daytona snapshots from CI, with retries and paged state verification (930a99f, 5379037, 4e713a7) Agent tooling: - Add and narrow the amika-cli skill for agents (9b6be25, 8cfc32a) - Add [release <symbol>] prefix and release trailers to the CLI release skill (59526b2) Release-Component: amika Release-Version: v0.14.0
dbmikus
added a commit
that referenced
this pull request
Aug 10, 2026
Releases the `amika` CLI at v0.14.0 and rolls that release into the sandbox base image. Two commits: 1. **`[release amika] Bump install.sh DEFAULT_VERSION to 0.14.0`** — the public CLI release. Carries the `Release-Component` / `Release-Version` trailers. 2. **`Set Amika base snapshot to install amika CLI v0.14.0 and repin amikad`** — bumps `AMIKA_VERSION` to 0.14.0 in `go/internal/sandbox/presets/base/Dockerfile` and repins `AMIKAD_SOURCE_REF` from `9dccbfd` to `4c7b647` (current `main`). The amikad repin matters on its own: the old pin predated the no-relay connect-token work, so sandbox images were building an amikad without the connect-token round trip, the sshd-manager fixes, or the state contract additions. The new ref resolves through the module proxy the builder stage's `go install` uses (`github.com/gofixpoint/amika/go v0.0.0-20260810034344-4c7b647bbeb8`). ## Changes since amika@v0.13.0 **Direct (no-relay) SSH transport** - Define and tighten the no-relay SSH contracts and vertical-slice spec (fc01f30, 650b433, dac6b6d) - Implement the local no-relay SSH path and fix its runtime lifecycle (d4bb156, 05c6df1) - Add `amika scpv2` over the direct WebSocket transport (9dccbfd) - Bind the managed sshd to a reserved loopback port (2e90dc6) - Scope v2 SSH session config per control plane (c7063c7) - Resolve SSH relay review annotations and document the connect-token round trip (#322) **SSH key handling** - Harden authorized key handling and close an ownership race (b565213, f448546, 3fde13c) - Add an amikad `authorized-keys clear` subcommand (0e2fa59) - Add the `amika secret ssh-key` command group (#324) **Sandbox images** - Build and package amikad into the base images (6279f28, f336617) - Repin the reviewed amikad source as fixes landed (862cbbd, 4777f5c, f864496, a6a4c04) - Add sandbox codev2 editor support (#325) **Testing and CI** - Test snapshot scrubbing end to end (#323) - Publish linux-vm Daytona snapshots from CI, with retries and paged state verification (930a99f, 5379037, 4e713a7) **Agent tooling** - Add and narrow the amika-cli skill for agents (9b6be25, 8cfc32a) - Add `[release <symbol>]` prefix and release trailers to the CLI release skill (59526b2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification