feat: stream agent stdout/stderr in real time (closes #156) - #262
Open
piyushbag wants to merge 1 commit into
Open
feat: stream agent stdout/stderr in real time (closes #156)#262piyushbag wants to merge 1 commit into
piyushbag wants to merge 1 commit into
Conversation
Remote wait-mode agent-send buffered the full HTTP response before printing. Route default remote wait through SSH with live stdout/stderr, matching local docker exec behavior. Keep the HTTP agent-send path for --session-id and --new-session. Stream materialize stderr during runs. Closes gofixpoint#156
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remote
amika sandbox agent-send(wait mode) buffered the full agent response through the synchronousPOST .../agent-sendAPI before printing anything. Local--localsandboxes already streamed viadocker exec. This PR routes default remote wait-mode agent-send over SSH with live stdout/stderr, matching local behavior and the CLI docs.Server-managed sessions (
--session-id,--new-session) still use the HTTP agent-send API so session IDs and structured responses stay on the control plane.Also stream materialize stderr to the host as commands run instead of holding it in a buffer until completion.
Changes
go/internal/ssh/ssh.go: addRunSSHfor streaming remote commands withoutsyscall.Execgo/cmd/amika/sandbox/sandbox_agent.go: default remote wait path uses SSH streaming; HTTP path kept for session flagsgo/internal/materialize/materialize.go: write stderr toos.Stderrduring executionRunSSHTest plan
go -C go test ./internal/ssh/... ./internal/materialize/... ./cmd/amika/sandbox/... -run 'TestBuildRemote|TestRunSSH|TestRun_'make fmt vet lint build(from repo root)amika sandbox agent-send <name> "..."shows output as the agent runsamika sandbox agent-send <name> "..." --session-id <id>still returns structured HTTP responseCloses #156