-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(middleware/cache): fix typo #3145
chore(middleware/cache): fix typo #3145
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
WalkthroughThe change involves an update to a comment in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
middleware/cache/cache.go (1)
120-120
: Approved: Comment correction improves accuracy.The change from "Cache Entry not found" to "Cache Entry found" is correct and aligns with the logic of the
if e != nil
block. This fix improves the code's readability and accurately describes the state at this point in the function.For even more clarity, consider expanding the comment slightly:
- // Cache Entry found + // Cache Entry found, now check for invalidation and expirationThis additional context helps readers understand the subsequent steps in the function.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- middleware/cache/cache.go (1 hunks)
Additional comments not posted (1)
middleware/cache/cache.go (1)
Line range hint
1-324
: Overall assessment: PR objectives met successfully.This PR successfully addresses the reported typo in the comment, improving code consistency as intended. The change is non-breaking and enhances the readability of the codebase. No functional changes were made, so existing tests and documentation remain valid.
Great job on catching and correcting this comment! It's a small change, but it significantly improves the accuracy of the code documentation.
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
There was a comment
Cache Entry not found
before the process when the cache was hit.I think this is a typo, please check them.
thank you.
Type of change
Checklist
Before you submit your pull request, please make sure you meet these requirements:
/docs/
directory for Fiber's documentation.