-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(whats_new.md): CORS middleware #2979
Conversation
WalkthroughThe recent update in the Fiber app enhances the CORS middleware by transitioning key fields like Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedLanguageTool (116)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Out of diff range and nitpick comments (2)
docs/whats_new.md (2)
Line range hint
8-8
: Correct the grammatical error in the caution note.- Its a draft, not finished yet. + It's a draft, not finished yet.
Line range hint
19-19
: Consider rephrasing to avoid wordiness.Instead of "a lot of new features, improvements, and breaking changes," consider "numerous new features, enhancements, and significant changes."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (3)
docs/whats_new.md (3)
Line range hint
8-8
: Correct the contraction in the caution note.- Its a draft, not finished yet. + It's a draft, not finished yet.
Line range hint
19-19
: Consider rephrasing "a lot of" to make the text more concise.Consider using "numerous" or "many" instead of "a lot of" for a more formal tone.
107-107
: Strengthen the wording in the introduction to the CORS middleware updates.Consider using "Here are the enhancements to the CORS middleware:" to introduce the changes more assertively.
Will check it tomorrow |
This pull request updates the
whats_new.md
with changes to the CORS middleware Config struct. The migration guide in the description provides an example of how to update the code.Summary by CodeRabbit