Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Update Version Numbers in Docs #2853

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Conversation

nickajacks1
Copy link
Member

Description

Update Go and Fiber version numbers in docs for v3.

Changes Introduced

List the new features or adjustments introduced in this pull request. Provide details on benchmarks, documentation updates, changelog entries, and if applicable, the migration guide.

  • Benchmarks: Describe any performance benchmarks and improvements related to the changes.
  • Documentation Update: Detail the updates made to the documentation and links to the changed files.
  • Changelog/What's New: Include a summary of the additions for the upcoming release notes.
  • Migration Guide: If necessary, provide a guide or steps for users to migrate their existing code to accommodate these changes.
  • API Alignment with Express: Explain how the changes align with the Express API.
  • API Longevity: Discuss the steps taken to ensure that the new or updated APIs are consistent and not prone to breaking changes.
  • Examples: Provide examples demonstrating the new features or changes in action.

Type of Change

Please delete options that are not relevant.

  • Documentation update (changes to documentation)

Checklist

Before you submit your pull request, please make sure you meet these requirements:

  • Followed the inspiration of the Express.js framework for new functionalities, making them similar in usage.
  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Updated the documentation in the /docs/ directory for Fiber's documentation.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.
  • Ensured that new and existing unit tests pass locally with the changes.
  • Verified that any new dependencies are essential and have been agreed upon by the maintainers/community.
  • Aimed for optimal performance with minimal allocations in the new code.
  • Provided benchmarks for the new code to analyze and improve upon.

@nickajacks1 nickajacks1 requested a review from a team as a code owner February 11, 2024 22:30
@nickajacks1 nickajacks1 requested review from gaby, sixcolors, ReneWerner87 and efectn and removed request for a team February 11, 2024 22:30
@gaby
Copy link
Member

gaby commented Feb 11, 2024

@gofiber/maintainers go1.20 is EOL since last week. Do we keep it or bump the min version to go1.21 ?

https://endoflife.date/go

@gaby
Copy link
Member

gaby commented Feb 11, 2024

I think we can keep 1.20 for now, fasthttp is also moving to 1.20 as their min version. A lot of systems don't support 1.21/1.22 yet

@efectn
Copy link
Member

efectn commented Feb 11, 2024

I think we can keep 1.20 for now, fasthttp is also moving to 1.20 as their min version. A lot of systems don't support 1.21/1.22 yet

I think we should just support 2 latest major versions of Go in v3 but let's discuss it later it should not block the PR

@efectn efectn merged commit 18f0f87 into gofiber:main Feb 11, 2024
1 check passed
@nickajacks1 nickajacks1 deleted the doc-updates branch February 11, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants