-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update startup message formatting #2847
Conversation
BEFORE: ``` _______ __ / ____(_) /_ ___ _____ / /_ / / __ \/ _ \/ ___/ / __/ / / /_/ / __/ / /_/ /_/_.___/\___/_/ v3.0.0-beta.1 -------------------------------------------------- INFO Server started on http://127.0.0.1:8003 (bound on host 0.0.0.0 and port 8003) INFO Application name: TEST APP INFO Total handlers count: 5 INFO Prefork: Disabled INFO PID: 2342 INFO Total process count: 1 20:49:50 | 200 | 593.769µs | 123.123.123.123 | GET | / ``` AFTER: ``` _______ __ / ____(_) /_ ___ _____ / /_ / / __ \/ _ \/ ___/ / __/ / / /_/ / __/ / /_/ /_/_.___/\___/_/ v3.0.0-beta.1 -------------------------------------------------- INFO Server started on: http://127.0.0.1:8003 (bound on host 0.0.0.0 and port 8003) INFO Application name: TEST APP INFO Total handlers count: 5 INFO Prefork: Disabled INFO PID: 2342 INFO Total process count: 1 20:49:50 | 200 | 593.769µs | 123.123.123.123 | GET | / ```
@the-hotmann The changes have to be run through https://github.com/mvdan/gofumpt the formatting is making golangci-lint to fail. |
Should work now. Hmm .. |
Lol I just called the commit |
If it fails again run this: go install mvdan.cc/gofumpt@latest
gofumpt -l -w listen.go |
Nvmd, it passed this time :-) |
@gaby I already ran |
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
BEFORE:
AFTER:
Here some requested screenshots from different shalls (
sh
&bash
&dash
):SH:
![image](https://private-user-images.githubusercontent.com/17692860/303859639-230ff49b-2787-4687-bc80-53c7a2d0660a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MjM0MTAsIm5iZiI6MTczODgyMzExMCwicGF0aCI6Ii8xNzY5Mjg2MC8zMDM4NTk2MzktMjMwZmY0OWItMjc4Ny00Njg3LWJjODAtNTNjN2EyZDA2NjBhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDA2MjUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ0YTJkY2Q1M2NhZDc1NzJjMzllMzU4ZWY3NGI1ZGVkM2JmNzNiNTQ5MzNmZDU2OGZlMzcwOTJkYjI1YjUxZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Nuu_bbUkU6f2xQWBCZHGtNNiu6zk9yJ82_CUVhdPVbk)
BASH:
![image](https://private-user-images.githubusercontent.com/17692860/303859650-e18f32d5-3898-470b-84df-4ca4816e9369.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MjM0MTAsIm5iZiI6MTczODgyMzExMCwicGF0aCI6Ii8xNzY5Mjg2MC8zMDM4NTk2NTAtZTE4ZjMyZDUtMzg5OC00NzBiLTg0ZGYtNGNhNDgxNmU5MzY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDA2MjUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3YmY1NGE0MDZiMmU2MGQ5NGU3NzljYWI4NTkyYjhhMDgwY2NlMzk1NGI2NTg5OGJmMWRlMTI1MDdlZTdlOTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bI6OJJk9EEbQ7btaQklzgc9RhkifliP0-XGr2jNmVYk)
DASH:
![image](https://private-user-images.githubusercontent.com/17692860/303859680-76fb8524-b9fe-482b-9973-bcf61e797305.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MjM0MTAsIm5iZiI6MTczODgyMzExMCwicGF0aCI6Ii8xNzY5Mjg2MC8zMDM4NTk2ODAtNzZmYjg1MjQtYjlmZS00ODJiLTk5NzMtYmNmNjFlNzk3MzA1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDA2MjUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNhN2YyYzIxN2NmYTJkNjliZDFiYzdlMmE3M2Q3OTk2NGM5ZDc5MDJkYzhjMzMyOTQzMWNhZjZlZTc4Y2RhMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9YCwj8A1ZDdGPkHgYe6QNrnqdSV5TKGvy5SoyoYBA1k)