Skip to content

Bump golangci-lint to v1.56.1 #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Bump golangci-lint to v1.56.1 #2842

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e0bf65f
Update linter.yml
gaby Feb 10, 2024
726c47c
Merge branch 'main' into bump-cilint
gaby Feb 10, 2024
b9a3cb8
Disable spancheck, fix some of the errors
gaby Feb 10, 2024
ecc06f6
Fix ErrorAs, disable go-require from testifylint
gaby Feb 11, 2024
7f21bfc
Remove extra space
gaby Feb 11, 2024
e248fdf
Fix all warnings from golangci-lint and revive unused params
gaby Feb 11, 2024
8d61c3c
Refactor CopyContextToFiberContext
gaby Feb 11, 2024
9cc6a30
Update adaptor.go
gaby Feb 11, 2024
bbc7a47
Merge branch 'main' into bump-cilint
gaby Feb 11, 2024
699a434
Merge branch 'main' into bump-cilint
gaby Feb 11, 2024
3961f45
Merge branch 'main' into bump-cilint
gaby Feb 11, 2024
36d3ba5
Merge branch 'main' into bump-cilint
gaby Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
# NOTE: Keep this in sync with the version from .golangci.yml
version: v1.55.2
version: v1.56.1
2 changes: 2 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ issues:
exclude-use-default: false

linters:
disable:
- spancheck
enable:
- asasalint
- asciicheck
Expand Down
4 changes: 2 additions & 2 deletions app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@ func Test_App_ShutdownWithContext(t *testing.T) {
ln := fasthttputil.NewInmemoryListener()

go func() {
require.NoError(t, app.Listener(ln))
require.NoError(t, app.Listener(ln)) //nolint:testifylint // Needed for test
}()

time.Sleep(1 * time.Second)
Expand Down Expand Up @@ -1543,7 +1543,7 @@ func Test_App_ReadTimeout(t *testing.T) {
time.Sleep(500 * time.Millisecond)

conn, err := net.Dial(NetworkTCP4, "127.0.0.1:4004")
require.NoError(t, err)
require.NoError(t, err) //nolint:testifylint // Needed for test
defer func(conn net.Conn) {
err := conn.Close()
require.NoError(t, err)
Expand Down