Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ v3 (feature): add support for custom constraints #2807

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

efectn
Copy link
Member

@efectn efectn commented Jan 23, 2024

Description

This pull requests add support for registering external constraints to fiber.
Fixes #2783

Changes Introduced

  • Benchmarks: Describe any performance benchmarks and improvements related to the changes.
  • Documentation Update: Detail the updates made to the documentation and links to the changed files.
  • Changelog/What's New: Include a summary of the additions for the upcoming release notes.
  • Migration Guide: If necessary, provide a guide or steps for users to migrate their existing code to accommodate these changes.
  • API Alignment with Express: Explain how the changes align with the Express API.
  • API Longevity: Discuss the steps taken to ensure that the new or updated APIs are consistent and not prone to breaking changes.
  • Examples: Provide examples demonstrating the new features or changes in action.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to existing features and functionality)
  • Documentation update (changes to documentation)

Checklist

  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Updated the documentation in the /docs/ directory for Fiber's documentation.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.

Commit Formatting

Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md

@efectn efectn added this to the v3 milestone Jan 23, 2024
@ReneWerner87
Copy link
Member

big thx
will review it tomorrow morning, it's on my list

app.go Show resolved Hide resolved
docs/guide/routing.md Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
Copy link
Member

@sixcolors sixcolors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider some of the comments, but overall, everything LGTM!

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReneWerner87
Copy link
Member

@efectn could you also fix the lint hints
image

@efectn efectn force-pushed the v3-constraint-extend branch from 27a1d6e to 9afcebc Compare January 25, 2024 15:08
@ReneWerner87
Copy link
Member

just a bench is missing, after this, i will merge

@ReneWerner87 ReneWerner87 merged commit 2a2801f into main Feb 2, 2024
11 checks passed
@efectn efectn deleted the v3-constraint-extend branch February 2, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 [v3 Proposal]: Enabling External Registration of Constraints for Router API
4 participants