Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Test: Speed up addon/retry tests #2800

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

nickajacks1
Copy link
Member

Description

There was a test that used the default exponential backoff configuration, causing the test to run for over 3 minutes. This test does not increase coverage in a way that warrants the slowdown of CI, and the default backoff time values are already verified by a separate test.

Alternatively, the test could be added to a separate file, disabled by default using build tags.

Type of Change

  • Code consistency (non-breaking change which improves code reliability and robustness)

Checklist

Before you submit your pull request, please make sure you meet these requirements:

  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.
  • Ensured that new and existing unit tests pass locally with the changes.
  • Aimed for optimal performance with minimal allocations in the new code.

There was a test that used the default exponential backoff
configuration, causing the test to run for over 3 minutes. This test
does not increase coverage in a way that warrants the slowdown of CI,
and the default backoff time values are already verified by a separate
test.
@ReneWerner87 ReneWerner87 merged commit f2e9c1f into gofiber:main Jan 15, 2024
12 checks passed
@nickajacks1 nickajacks1 deleted the testing-retry branch February 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants