Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookie.go #2538

Closed
wants to merge 1 commit into from
Closed

Conversation

Hasan-Kilici
Copy link

Description

although the performance difference is not much, there is a possibility that it will run 2-4ms faster this way

@welcome
Copy link

welcome bot commented Jul 9, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the v3 branch, which I'm not sure if it's still active, last change was in March 3rd, and there aren't many details in discord either

Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this change is needed

@ReneWerner87
Copy link
Member

@Hasan-Kilici friendly ping

@leonklingele
Copy link
Member

Any benchmarks on this? I doubt it will actually improve performance.

@efectn efectn closed this Sep 10, 2023
@ReneWerner87 ReneWerner87 added this to the v3 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants