-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: allow preloaded certs with prefork #2351
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit-tests to the new exported functions?
does it make sense? I mean there are already unit tests for ListenMutualTLS and ListenTLS. And ListenMutualTLS/ListenTLS calls ListenMutualTLSWithCertificate/ListenTLSWithCertificate with already loaded file. If i create a unit test for ListenMutualTLSWithCertificate i just copy the content from ListenMutual to a unit test. |
I think having an exported function without tests will lower the coverage % 🤔 |
@gaby i created tests for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
Currently I have a function that generates or loads these keys according to different conditions.
Now I would have to save them temporarily as a file to be able to use the full functions of fiber.
The added functions allow me to specify the already loaded keys.
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Oh! Its too late :c should i recreate my pull request?