-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Fix: Properly handle error of "net.ParseCIDR" in "(*App).handleTrustedProxy" #2243
Merged
ReneWerner87
merged 4 commits into
gofiber:master
from
leonklingele:fix-app-handleTrustedProxy
Dec 5, 2022
Merged
🩹 Fix: Properly handle error of "net.ParseCIDR" in "(*App).handleTrustedProxy" #2243
ReneWerner87
merged 4 commits into
gofiber:master
from
leonklingele:fix-app-handleTrustedProxy
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the individual commits for details. |
li-jin-gou
suggested changes
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
efectn
approved these changes
Nov 27, 2022
@leonklingele can you please add one more test case for this kind of behavior |
9a1e5af
to
b454fb2
Compare
b454fb2
to
bf59d2b
Compare
Updated, ptal. |
ReneWerner87
approved these changes
Dec 5, 2022
li-jin-gou
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*net.IPNet
in case of an error ofnet.ParseCIDR
ctx.IsProxyTrusted()
ctx.IsProxyTrusted()
by caching method callType of change
Please delete options that are not relevant.
Checklist: