PR: add url for favicon middleware, for correct handling different of…

[0xdeface]

Description

Presently ico url might be only /favicon.ico but some resource wants url exactly /favicon.svg for svg format.
I added new property to favicon config and default value with /favicon.ico. Also i changed docs for this middleware

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Checklist:

• For new functionalities I follow the inspiration of the express js framework and built them similar in usage
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
• I tried to make my code as fast as possible with as few allocations as possible
• For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

[welcome]

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[li-jin-gou]

Add pr Description according to pull request template.

[pjebs]

Shouldn't the file be cached using sync.Once?

[0xdeface]

Sorry, I did not understand, what I should do? Use sync.once?

[0xdeface]

Shouldn't the file be cached using sync.Once?

i didn't change any cache behaviour in this pr. please explain where i should add sync.once?

[ReneWerner87]

I'll try to take a look at the pull request tomorrow, if I know what he means or have other comments I'll let you know

[pjebs]

My mistake. I thought the middleware's job was to return a (cached) binary version of the favicon.

[ReneWerner87]

@0xdeface couldn't you save the internal configuration switch by specifying the route when using the middleware ?

example

app.Use("/favicon.svg", favicon.New())

or

app.Use("/favicon.:ext", favicon.New())

you could make this feature much more usable and would only have to deactivate the internal matching in such a case.

[leonklingele]

Also make sure to update middleware/favicon/README.md accordingly. Currently it says This middleware is exclusively for serving the default, implicit favicon, which is GET /favicon.ico.

[ReneWerner87]

@0xdeface Hi can check the last comments and suggestions for improvement

hope we can still customize it so that we provide this feature in the next version

[0xdeface]

Hi, i will check comments and put changes on next week.

[leonklingele]

@0xdeface did you get a chance to work on this so far? 😊

[renanbastos93]

LGTM, please consider suggestion by @leonklingele

[efectn]

@leonklingele can you check the PR again

[leonklingele]

lgtm, good work @0xdeface! 🥳

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord