Fix and optimize memory storage #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a TOCTOU problem between a mutex rlock and a mutex lock.
|
See the individual commits for details. |
|
Why is there a similar memory storage available here: https://github.com/gofiber/fiber/tree/e388e0edb3c6d4bdbfa41e8d533e1f4bd734404d/internal/storage/memory ? |
|
One is for testing the storage package Check the first comment line in the file |
|
@leonklingele can you pls apply this changes to the internal sorage/memory test adapter and later to https://github.com/gofiber/storage/blob/main/memory/memory.go#L116 |
This fixes a TOCTOU problem between a mutex rlock and a mutex lock.
|
@ReneWerner87 done. |
ReneWerner87
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.