-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve memory storage #2162
Merged
Merged
Improve memory storage #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory storage optimized: Benchmark_Memory/fiber_memory-12 7950 153780 ns/op 616 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 9714 134795 ns/op 657 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 9558 122996 ns/op 645 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 9392 130914 ns/op 635 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 8590 123949 ns/op 645 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 9662 126010 ns/op 703 B/op 0 allocs/op original storage: Benchmark_Memory/fiber_memory-12 3972 282395 ns/op 662 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 4204 279402 ns/op 723 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 4239 278725 ns/op 619 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 4239 302900 ns/op 717 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 4288 282079 ns/op 703 B/op 0 allocs/op
Benchmark_Memory/fiber_memory-12 4221 280041 ns/op 721 B/op 0 allocs/op |
|
efectn
requested changes
Oct 19, 2022
Will merge it later |
efectn
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
until then it was not clear for which internal memory storage is used, this i tried to describe better and optimize the code for it
the code of the storages have been updated
i also provided functionalities which create timestamps more performant when needed
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/