-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: multi-byte AppName displays confusion #2148
Conversation
don't know if we should include this in the go.mod i know fenny does not like dependencies to other packages, so he had made copies we should treat the 3 packages from mattn the same in any case so either make copies or put them all as dependencies in the go.mod @gofiber/maintainers what do you think? |
I support putting deps into the go.mod but gopsutil is really bloat dependency 🤔 |
8709f6e
to
3c00f87
Compare
3c00f87
to
e3dc923
Compare
@li-jin-gou can you
|
Sorry, I just saw it now and I will do so |
Thx |
e3dc923
to
ad8cfd4
Compare
I'm going to merge this PR. cc @ReneWerner87 @efectn |
give me a few minutes, i will merge it |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?
Fixes #2147
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/