Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feature: customizable colors #1977

Merged
merged 3 commits into from
Aug 1, 2022
Merged

✨ feature: customizable colors #1977

merged 3 commits into from
Aug 1, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Jul 13, 2022

close #1890

ReneWerner87
ReneWerner87 reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put all colors and color related functions in a separate file to keep the app.go clean and small?

@efectn
Copy link
Member Author

efectn commented Jul 13, 2022 •
edited
Loading

Can you please put all colors and color related functions in a separate file to keep the app.go clean and small?

Maybe i can create listen.go for color and listen related methods. Is it ok to you?

@ReneWerner87
Copy link
Member

ReneWerner87 commented Jul 14, 2022 •
edited
Loading

For the colors a color(s).go or theme.go and for the listen stuff a listen.go

@efectn
Copy link
Member Author

efectn commented Jul 14, 2022

For the colors a color(s).go or theme.go and for the listen stuff a listen.go

done

@ReneWerner87
Copy link
Member

@efectn pls add documentation in the readme and here https://github.com/gofiber/docs/pulls

@ReneWerner87 ReneWerner87 merged commit 4103f94 into master Aug 1, 2022
@ReneWerner87 ReneWerner87 mentioned this pull request Aug 1, 2022
Merged
@efectn efectn deleted the edit-colors branch August 1, 2022 18:58
trim21 pushed a commit to trim21/fiber that referenced this pull request Aug 15, 2022
@efectn @trim21
✨ feature: customizable colors (gofiber#1977)
cf18767 
* ✨ feature: customizable colors

* ✨ feature: customizable colors

* ✨ feature: customizable colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

Assignees
No one assigned
Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 The text color is too dark on linux terminal.
2 participants
@efectn @ReneWerner87