-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/valyala/fasthttp from 1.35.0 to 1.37.0 #1882
Bump github.com/valyala/fasthttp from 1.35.0 to 1.37.0 #1882
Conversation
@dependabot rebase |
89f6ee9
to
c06d35b
Compare
we have to check this changes |
in new release vs and our additional code Lines 1349 to 1408 in 2326297
|
@dependabot rebase |
Bumps [github.com/valyala/fasthttp](https://github.com/valyala/fasthttp) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/valyala/fasthttp/releases) - [Commits](valyala/fasthttp@v1.35.0...v1.36.0) --- updated-dependencies: - dependency-name: github.com/valyala/fasthttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
c06d35b
to
72173eb
Compare
i tested serval things, but the path is not working for the Send_Immutable test in our windows test machine code changes in fasthttp: |
problem is this change, whenever the fs handler differs from the normal one and we have to do this because of our wanted customizations for the sendFile method, the path is made the absolute path so it is not possible that our sendFile works with absolute paths the fact that it works on linux is that the absolute path there is a slash "/" and is stripped in the next lines, so the path is then empty the real problem here is Windows: and fasthttp is skipping the tests for windows^^ |
hi @erikdubbelboer, we just have problems with the update to fasthttp 1.36.0 our tests for windows machines have failed due to the above mentioned adjustments would it be possible to make this part optional |
What would you need an empty root for? I don't know your specific case but wouldn't setting it to |
we need the empty root to allow the users to pass an absolute path like your serveFile functionality unfortunately we can not use your function, because we want to customize the behavior in case of error and the configuration possibilities. so fenny had copied it back then and we kept this code in sync as far as possible only by the line, which looks if the configuration deviates from the standard is a customization no longer possible for us
slash would work for linux, because the function as described above, then removes the slash and an empty string is present but on windows, the filePath.isAbs recognizes that it is not an absolute path and changes it directly to the current execution location best would be, if we can also skip this modification of the configured root |
Yeah on Windows you shouldn't pass a |
I have already tested if i mount a fixed drive with linux this is no problem, because under slash is everything |
I see 2 options:
|
Okay thanks for your assessment so solution number 1 would not be my favorite as it would not be good performance wise I will create a pull request(solution 2) |
this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment)
this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment)
* Add an option to allow empty root in the fsHandler this is necessary to restore the capabilities before the commit c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment) * Add an option to allow empty root in the fsHandler this is necessary to restore the capabilities before the commit c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment) * Update fs.go Co-authored-by: Erik Dubbelboer <[email protected]> * Update fs.go Co-authored-by: Erik Dubbelboer <[email protected]> Co-authored-by: Erik Dubbelboer <[email protected]>
A newer version of github.com/valyala/fasthttp exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
yeah i will update this PR with the new version |
* Bump github.com/valyala/fasthttp from 1.35.0 to 1.36.0 Bumps [github.com/valyala/fasthttp](https://github.com/valyala/fasthttp) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/valyala/fasthttp/releases) - [Commits](valyala/fasthttp@v1.35.0...v1.36.0) --- updated-dependencies: - dependency-name: github.com/valyala/fasthttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump github.com/valyala/fasthttp from 1.35.0 to 1.36.0 gofiber#1882 * Bump github.com/valyala/fasthttp from 1.35.0 to 1.36.0 gofiber#1882 * Bump github.com/valyala/fasthttp from 1.35.0 to 1.36.0 gofiber#1882 * Bump github.com/valyala/fasthttp from 1.35.0 to 1.36.0 gofiber#1882 * Bump github.com/valyala/fasthttp from 1.35.0 to 1.36.0 gofiber#1882 * Bump github.com/valyala/fasthttp from 1.35.0 to 1.37.0 gofiber#1882 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: wernerr <[email protected]>
* Add an option to allow empty root in the fsHandler this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment) * Add an option to allow empty root in the fsHandler this is necessary to restore the capabilities before the commit valyala@c7576cc and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards gofiber/fiber#1882 (comment) * Update fs.go Co-authored-by: Erik Dubbelboer <[email protected]> * Update fs.go Co-authored-by: Erik Dubbelboer <[email protected]> Co-authored-by: Erik Dubbelboer <[email protected]>
Bumps github.com/valyala/fasthttp from 1.35.0 to 1.37.0.
Release notes
Sourced from github.com/valyala/fasthttp's releases.
Commits
7cc6f4c
Fix DoTimeout Streaming body bug9a0b4d0
optimize (#1275)e3d2512
optimize (#1272)b40b5a4
Update tlsClientHandshake (#1263)c7576cc
Added Windows support and removed some panics (#1264)f0e1be5
add nil check of req.body and resp.body on ReleaseBody (#1266)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)