🐛 [Bug]: requestId middleware still only accepts string for ContextKey config value, should be any like c.Locals.
#2356
Labels
Comments
|
Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
|
@benjajaja can you help us with a pull request? |
|
yea I can find some time |
benjajaja
added a commit
to benjajaja/fiber
that referenced
this issue
Mar 13, 2023
Consistent with c.Locals(key inteface{}, ...).
Fixes gofiber#2356
6 tasks
benjajaja
added a commit
to benjajaja/fiber
that referenced
this issue
Mar 13, 2023
Consistent with c.Locals(key inteface{}, ...).
Fixes gofiber#2356
ReneWerner87
pushed a commit
that referenced
this issue
Mar 14, 2023
requestid.Config.ContextKey is interface{}
Consistent with c.Locals(key inteface{}, ...).
Fixes #2356
This was referenced Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
#2143 allows to use
anyas key forc.Locals(key, v). The RequestID middleware should be consistent with that.This allows to use a custom type for context keys, like for other keys. The RequestID is likely read back somewhere else along other context keys.
How to Reproduce
See https://docs.gofiber.io/api/middleware/requestid#config
Expected Behavior
https://docs.gofiber.io/api/middleware/requestid#config should have
ContextKey interface{}Fiber Version
v2.42.0
Code Snippet (optional)
No response
Checklist:
The text was updated successfully, but these errors were encountered: