Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add requestId #59

Merged
merged 2 commits into from
Jan 21, 2022
Merged

add requestId #59

merged 2 commits into from
Jan 21, 2022

Conversation

oh0123
Copy link

@oh0123 oh0123 commented Jan 19, 2022

add request id to track every request

@efectn efectn self-requested a review January 19, 2022 08:28
efectn
efectn requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add requestId into the unit tests?

@oh0123
Copy link
Author

oh0123 commented Jan 20, 2022

Can you add requestId into the unit tests?

sure, here you are

@efectn efectn self-requested a review January 20, 2022 06:58
@efectn efectn added the ✏️ Feature New feature or request label Jan 20, 2022
@ReneWerner87 ReneWerner87 merged commit d5ab163 into gofiber:main Jan 21, 2022
@oh0123 oh0123 deleted the add-requestId-pr branch January 22, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efectn efectn efectn approved these changes

Assignees
No one assigned
Labels
✏️ Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oh0123 @efectn @ReneWerner87