fix(tooltip): when toggleVisibility give nativeElement display:none p… #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elite-lucas what exactly is the issue this solves? |
|
Issue #326 |
goetzrobin
reviewed
Jul 10, 2024
There was a problem hiding this comment.
@elite-lucas let me know if you can remove the visibility style
jackyshows
pushed a commit
to jackyshows/spartan
that referenced
this pull request
Jul 27, 2024
goetzrobin
pushed a commit
that referenced
this pull request
Aug 8, 2024
* feat(slider): add new slider component draft version * feat(slider): remove non used imports * feat(slider): adapt code to biome linting * feat(slider): adapt code to biome linting * fix(tooltip): when toggleVisibility give nativeElement display:none property (#327) * feat(slider): features addition and code optimization Add directionality support, basic focus behavior and appearance, and resize behavior. * feat(slider): implement full accessible slider according to WAI * feat(slider): add step and tick mark features, adapt styles to shadcn ui * feat(slider): add component tests * feat(slider): remove circular dependencies --------- Co-authored-by: elite-lucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roperty
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information