Skip to content

Delete .travis.yml#76

Merged
soc1c merged 1 commit into
masterfrom
s1-ci-cleanup
Mar 23, 2019
Merged

Delete .travis.yml#76
soc1c merged 1 commit into
masterfrom
s1-ci-cleanup

Conversation

@soc1c
Copy link
Copy Markdown

@soc1c soc1c commented Mar 23, 2019

to prepare upstream merge

@soc1c soc1c added this to the 0.1 consensus engine milestone Mar 23, 2019
@soc1c soc1c merged commit 455cd93 into master Mar 23, 2019
@soc1c soc1c deleted the s1-ci-cleanup branch March 23, 2019 10:25
@jleni
Copy link
Copy Markdown
Member

jleni commented Mar 23, 2019

When is Clique planned to merge upstream?
This change disables CI and travis does not build PRs anymore

Some alternatives:

  • Best: politely ask parity if they mind having that file in their repo. In practice any external team contributing but without access to gitlab would find that useful.
  • Plan B: branch parity-goerly/master to upstream_pr and adjust things only there?
  • Plan Z: keep this file until the last moment so we dont lose CI.

@jleni jleni mentioned this pull request Mar 23, 2019
Closed
@soc1c
Copy link
Copy Markdown
Author

soc1c commented Mar 23, 2019

According to plan Z, this is the last moment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A0-pleasereview 🤓 M1-ci 🙉

Projects

None yet

Milestone

0.1 consensus engine

Development

Successfully merging this pull request may close these issues.

2 participants

@soc1c @jleni