Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app crashes when adding a new folder or changing files around the project. #94639

Closed
Merzzyg1 opened this issue Jul 22, 2024 · 7 comments
Closed

Comments

@Merzzyg1
Copy link

Tested versions

-reproducible ins v4.3.beta3.official [82cedc8]. not reproducible in v4.3.beta.2.official

System information

Godot v4.3.beta3 - Android - Vulkan (Mobile) - integrated Adreno (TM) 740 - (8 Threads)

Issue description

when i try to make a new folder it just crashes on me. i have also tried with swapping files around. (ignore how long it took to press the options)

Screen_Recording_20240722_224929_One.UI.Home.mp4

Steps to reproduce

open app, make a new folder in any directory = crash

Minimal reproduction project (MRP)

as i was writting this i tried to export and it just keeps crashing when i open the app so yeahhh.
i tried to compress but the file ended up being 75 mb so i uploaded it to mediafire idk if thats ok or not but heres the link: https://www.mediafire.com/file/0h64m0ww464ygay/MRP.zip/file

@Merzzyg1
Copy link
Author

Adding into this. i just downloaded this version v4.3.beta2.official [b75f048] and it seems to work fine. i dare say this version feels faster than the other one i stated. .

@akien-mga
Copy link
Member

Tested on a Google Pixel 7a and I can't reproduce the crash. But I do see that creating a new folder trigger a rescan of all files in the FileSystem dock. That sounds like #94416.

Maybe the crash in your end is because your phone is less powerful and rescanning/reimporting 3D meshes might be too heavy for the GPU?

@Merzzyg1
Copy link
Author

Tested on a Google Pixel 7a and I can't reproduce the crash. But I do see that creating a new folder trigger a rescan of all files in the FileSystem dock. That sounds like #94416.

Maybe the crash in your end is because your phone is less powerful and rescanning/reimporting 3D meshes might be too heavy for the GPU?

Might be im going to check if it happens in a new project without 3d characters

@Merzzyg1
Copy link
Author

Tested on a Google Pixel 7a and I can't reproduce the crash. But I do see that creating a new folder trigger a rescan of all files in the FileSystem dock. That sounds like #94416.

Maybe the crash in your end is because your phone is less powerful and rescanning/reimporting 3D meshes might be too heavy for the GPU?

following up i have record both versions 4.3.2 and 4.3.3. i also had a recording of version 4.3.3 with a project with no files but that one was too large for github. to sumorise that video it worked flawlessly as expected so nothing interesting.

Here is the video of version 4.3.2

Screen_Recording_20240723_153911.mp4

in the video you can see how its running smoothly and the new folder was added quickly.

Here is the video of version 4.3.3

Screen_Recording_20240723_153555.mp4

i wasnt able to screen record the loading process because of file sizes (both videos were the same lenght but this one was 26 mbs... idk how) but it shows the app crashing for no reason. in both videos it was the same project which means its aproblem in 4.3.3 and after reading #94416 it might be connected. I believe my phone is capable to run the app so its a problem built in the newer version.

@akien-mga akien-mga moved this from Release Blocker to Very Bad in 4.x Release Blockers Jul 24, 2024
@akien-mga
Copy link
Member

Could you test this build from #94691?
https://github.com/godotengine/godot/actions/runs/10074692377/artifacts/1734400150

This should include an apk of the Android editor which you can sideload on your phone manually.

It should solve the problem of always reimporting files on any filesystem operation, which would be a duplicate of #94416.

What I'm still unsure of is why this reimport triggers a crash in your case. The crash might be a different bug, and might be reproducible in the "fixed" build or 4.3.beta2 if you delete the .godot folder to force a full reimport. Could you test that?

@Merzzyg1
Copy link
Author

Merzzyg1 commented Jul 24, 2024

Could you test this build from #94691?
https://github.com/godotengine/godot/actions/runs/10074692377/artifacts/1734400150

This should include an apk of the Android editor which you can sideload on your phone manually.

It should solve the problem of always reimporting files on any filesystem operation, which would be a duplicate of #94416.

What I'm still unsure of is why this reimport triggers a crash in your case. The crash might be a different bug, and might be reproducible in the "fixed" build or 4.3.beta2 if you delete the .godot folder to force a full reimport. Could you test that?

i have tried the build you sent me and it works now theres no crashes. it loads smoothly and deletes smoothly. changing folder names reloads without a problem. i also tried what you said about deleting the .godot file to force a reload of the full project and it realoaded with no problems whatsoever. conclusion the new build works.

im not sure either why it would crash in my case. but i think it might be a problem with he reloading getting into a loop which just crashes it But im not sure

Screen_Recording_20240724_140337.mp4
Screen_Recording_20240724_140242.mp4

@akien-mga
Copy link
Member

Thanks for testing! I'll close this as duplicate of #94416 and thus resolved by #94691.

The crash is worked around but the root cause for it might not be fixed yet. We'll have to see when fixing #94416 properly if we understand what could cause a crash on reimport.

@akien-mga akien-mga removed this from the 4.3 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants