Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialStorage warning with default project settings in compatibility renderer #93453

Closed
anniryynanen opened this issue Jun 22, 2024 · 3 comments

Comments

@anniryynanen
Copy link
Contributor

anniryynanen commented Jun 22, 2024

Edit: Not specific to Linux

Tested versions

  • Reproduces in v4.3.beta2.official [b75f048]
  • Doesn't reproduce in v4.3.beta1.official [a4f2ea9]

System information

Arch Linux #1 SMP PREEMPT_DYNAMIC Wed, 12 Jun 2024 20:17:17 +0000 - Tty - GLES3 (Compatibility) - Mesa Intel(R) Graphics (ADL GT2) - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)

Issue description

The default value for rendering/limits/global_shader_variables/buffer_size is 65536, which in compatibility renderer can produce the following warning:

MaterialStorage: Project setting "rendering/limits/global_shader_variables/buffer_size" exceeds maximum uniform buffer size of: 4096. Falling back on maximum buffer size.
  <C++ Source>   drivers/gles3/storage/material_storage.cpp:1115 @ MaterialStorage()

Whether the warning is issued or not seems to depend on hardware, it happens on my laptop but not on my desktop.

I'm not sure what should be changed here, the warning or the default, but I don't think a project with default settings should produce warnings.

Steps to reproduce

Create a new project and set renderer to Compatibility. Run the project.

Minimal reproduction project (MRP)

N/A

@patwork
Copy link
Contributor

patwork commented Jun 22, 2024

#85374
The limit at which the warning is displayed has changed. #92568

@anniryynanen
Copy link
Contributor Author

Removing "Linux" from the issue description, doesn't seem to be OS related.

@anniryynanen anniryynanen changed the title MaterialStorage warning with default project settings in Linux compatibility renderer MaterialStorage warning with default project settings in compatibility renderer Jun 22, 2024
@akien-mga akien-mga added this to the 4.3 milestone Jun 22, 2024
@akien-mga akien-mga pinned this issue Jun 22, 2024
@clayjohn
Copy link
Member

Duplicate of #85374

I wrote up a comment there on what I think the proper solution to this issue would be #85374 (comment)

@clayjohn clayjohn removed this from the 4.3 milestone Jun 22, 2024
@AThousandShips AThousandShips unpinned this issue Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants