Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in "GDScript: fix segfault on invalid script" with const foo : GDScript= preload(...) #92534

Closed
lyuma opened this issue May 30, 2024 · 0 comments · Fixed by #92544
Closed

Comments

@lyuma
Copy link
Contributor

lyuma commented May 30, 2024

#92035 causes a regression in projects which access inner classes from `const foo: GDScript = preload("./foo.gd"):

System info:
Godot v4.3.beta (8bf8f41) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)

MRP: GDScriptPreloadBug.zip

Steps to reproduce:

  1. Open the project. There are errors.
  2. Change test.gd from : GDScript = to := to infer type
  3. Errors go away. Uncheck and check the plugin and it should print Hello World
  4. Revert the change made in step 2.
  5. There are still no errors?!?!?!

This issue does not reproduce when this PR is backed out. The MRP works fine in Godot 4.0.3 through May 17 bd2300d.

Originally posted by @lyuma in #92035 (comment)

@lyuma lyuma changed the title Regression in PR #92035 Regression in "GDScript: fix segfault on invalid script" with const foo : GDScript= preload(...) May 30, 2024
@github-project-automation github-project-automation bot moved this to For team assessment in GDScript Issue Triage May 30, 2024
@dalexeev dalexeev moved this from Unassessed to Very Bad in 4.x Release Blockers May 30, 2024
@dalexeev dalexeev added this to the 4.3 milestone May 30, 2024
@dalexeev dalexeev moved this from For team assessment to Fix pending review in GDScript Issue Triage May 30, 2024
@github-project-automation github-project-automation bot moved this from Fix pending review to Done in GDScript Issue Triage May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Very Bad
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants