Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile renderer light_cull_mask is not respected #86062

Closed
victorbstan opened this issue Dec 12, 2023 · 4 comments
Closed

Mobile renderer light_cull_mask is not respected #86062

victorbstan opened this issue Dec 12, 2023 · 4 comments

Comments

@victorbstan
Copy link

victorbstan commented Dec 12, 2023

Tested versions

Godot 4.2

System information

Mac OS 14.1.2 (23B92) (M2), Godot 4.2, Mobile renderer

Issue description

Mobile renderer does not take into account light cull mask settings correctly

Screenshot 2023-12-12 at 8 04 16 AM Screenshot 2023-12-12 at 8 03 47 AM

Steps to reproduce

When using an OmniLight, with meshes on Layer 1 and 2, and setting OmniLight's light_cull_mask to Layer 2, and setting project renderer to Mobile, and playing the scene, (Editor may display correctly), see that OmniLight is displayed on mesh it is not supposed to. There also another problem, if you look closeley, you will see that lighting is brighter in Mobile renderer, because the light is both baked as well as displayed on top of baked meshes, It should not be displayed onto baked meshes, only onto dynamic/non-static meshes. (so there are at least two problems visible here)

Minimal reproduction project (MRP)

Light Cull Mask Mobile Issue.zip

@Calinou
Copy link
Member

Calinou commented Dec 12, 2023

Thanks for the report! Consolidating in #82263.

There also another problem, if you look closeley, you will see that lighting is brighter in Mobile renderer, because the light is both baked as well as displayed on top of baked meshes, It should not be displayed onto baked meshes, only onto dynamic/non-static meshes. (so there are at least two problems visible here)

This is being tracked in #85145.

@amarraff
Copy link

I'm experiencing this problem right now in v4.2.1.stable.official [b09f793]

I'm trying to have an omni light only light a specific layer, but it's still lighting every layer.

@Calinou
Copy link
Member

Calinou commented Apr 16, 2024

@amarraff As mentioned in my comment above, the issue is already being tracked in #82263.

@amarraff
Copy link

amarraff commented Apr 16, 2024

@Calinou

I did check it out, but my issue related more to the description of the one mentioned here than the one in #82263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants