Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looped animations can't transition automatically in state machine #81715

Closed
SaracenOne opened this issue Sep 15, 2023 · 2 comments · Fixed by #87171
Closed

Looped animations can't transition automatically in state machine #81715

SaracenOne opened this issue Sep 15, 2023 · 2 comments · Fixed by #87171

Comments

@SaracenOne
Copy link
Member

SaracenOne commented Sep 15, 2023

Godot version

5f1e56f

System information

Windows 11

Issue description

The state machines AnimationNodeAnimations appears to have broken in several ways. Firstly, the AtEnd transition no longer works for animations marked as looping or ping-pong, and the progress bar for the animation always appears as 'complete' regardless of its state. The regression seems to have crept in as part of this overhaul to the animation system (991e6e9).

The font colouring also appears to be broken in the master build, but this appears to be a seperate and much more recent issue.

Steps to reproduce

Create an AnimationTree with a state machine, creation an AnimationPlayer with one or more looped animations, add one of these to the AnimationTree state machine and create an AtEnd transition to another node. The animation will never execute the transtion.

Minimal reproduction project

animation_test_1.zip

@SaracenOne
Copy link
Member Author

#79400
Workaround by @TokageItLab, need to review

@TokageItLab
Copy link
Member

TokageItLab commented Sep 16, 2023

As mentioned in #79400 (comment), this is not a bug exactly, but rather an expected behavior to avoid unsemantic transitions. To solve this completely, the user should be able to arbitrarily define the remaining time of the upstream AnimationNode such as I commented in #57959 (comment), but the proposal is needed first.

@TokageItLab TokageItLab changed the title Looped animations break state machine behaviour Looped animations can't transition automatically in state machine behaviour Sep 16, 2023
@TokageItLab TokageItLab changed the title Looped animations can't transition automatically in state machine behaviour Looped animations can't transition automatically in state machine Sep 16, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.x Nov 14, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 23, 2024
@github-project-automation github-project-automation bot moved this from To Assess to Done in 4.x Priority Issues Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment