Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect music loop clips in Godot 4. #76307

Closed
ghost opened this issue Apr 20, 2023 · 4 comments
Closed

Perfect music loop clips in Godot 4. #76307

ghost opened this issue Apr 20, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 20, 2023

Godot version

4.0.2

System information

Windows 10

Issue description

I have a song that loops to an offset. This looping works perfectly in Godot 3 and Audacity, but Godot 4 introduces an ugly audio clip.
I will post a video so you can see what I mean.

Sorry if this is a duplicate, I tried looking for audio loop issues but didn't find anything that could be similar to mine. Except maybe issue #26931 but that one seems to go back to Godot 3, so I don't know if it applies.

I'm not sure what could be going on, maybe there's a small delay when looping? Or maybe the loop position is not being set correctly?

Steps to reproduce

N/A

Minimal reproduction project

N/A

@Calinou
Copy link
Member

Calinou commented Apr 21, 2023

@strellydev Please upload a minimal reproduction project to make this easier to troubleshoot.

Can you reproduce this after converting the music to MP3 or WAV?

@ghost
Copy link
Author

ghost commented Apr 21, 2023

Doesn't matter if it's ogg, mp3 or wav, the three of them make the clip sound, although I must say the mp3 clip is way less noticeable.

In Godot 3, only wav introduces the audio clip, and again, way less noticeable.

I searched again for similar issues using "pop" instead of "clip" and this one came about: #64775
But there it says the mp3 version of the song doesn't pop, so I'll still upload my sample project in case it's useful on detecting a similar issue with mp3 files.

You'll find the projects in the main issue post.
Edit: Actually I can't upload them because the wav file makes the project go over 50mb, so I can't upload it. I'll see if I can find a workaround.
Edit 2: I just dropped the wav file.

Edit 3: Okay this is very weird in Godot 3. Like I said, in Godot 3, wav introduces de "pop" sound, but it's kinda random, I sat there repeating the loop and some times it doesn't introduce it and others it does. So yeah, no clue what's going on with that.

@Calinou
Copy link
Member

Calinou commented Apr 21, 2023

Edit 3: Okay this is very weird in Godot 3. Like I said, in Godot 3, wav introduces de "pop" sound, but it's kinda random, I sat there repeating the loop and some times it doesn't introduce it and others it does. So yeah, no clue what's going on with that.

See #22016.

@ghost
Copy link
Author

ghost commented Apr 21, 2023

I will take a look at that, thanks, I'll close this issue too, seeing that it's covered by 64775.

Thanks for you support!

@ghost ghost closed this as completed Apr 21, 2023
@ghost ghost closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants