Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection disappears when replacing text forwards #69007

Closed
duianto opened this issue Nov 22, 2022 · 1 comment · Fixed by #91779
Closed

Text selection disappears when replacing text forwards #69007

duianto opened this issue Nov 22, 2022 · 1 comment · Fixed by #91779

Comments

@duianto
Copy link

duianto commented Nov 22, 2022

Godot version

v4.0.beta5.official [89a33d2]

System information

Windows 10 22H2, OpenGL3, Geforce GTX 550 Ti

Issue description

The text selection disappears when replacing text forwards enter

godot_4_replace_next.mp4

But the selection remains visible when replacing text backwards shift enter

godot_4_replace_previous.mp4

Steps to reproduce

  • Open the included project: issue, text selection disappears, replace text forwards.zip
  • In the bottom left panel: FileSystem
  • Double click on the script: new_script.gd
  • In the script editor, on line 3, double click on 123 to select the number
  • Press ctrl r to open the find and replace input boxes at the bottom of the script editor
  • With the replace input box focused, type 456
  • Press enter
    The instance of 123 on line 3 was replaced with 456 as expected, but...

Expected

The next occurrence should be selected, so that it's visible what will be replaced when enter is pressed again.

The expected behavior is observed when replacing backwards: shift enter
Now the next occurrence to be replaced is selected.

Observed

The text selection disappeared. This makes it difficult to see which occurrence will be replaced when enter is pressed again.

In this example it's easy to see the next occurrence, but it becomes difficult when the occurrences are on multiple columns and lines.

Minimal reproduction project

issue, text selection disappears, replace text forwards.zip

It's not project specific, it's reproducible in a new project with a new script file, the project doesn't even have to be saved.

It can also be reproduced with the default script template, it has four instances of the word "the".

I had already recorded the videos above when I noticed that simpler reproduction step.

@KoBeWi
Copy link
Member

KoBeWi commented May 7, 2024

Still valid in 4.3 dev6

@akien-mga akien-mga changed the title 4.0, replace text forwards, text selection disappears Text selection disappears when replacing text forwards May 7, 2024
@YeldhamDev YeldhamDev added this to the 4.3 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants