Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationPlayer's RESET track defaults to Continuous for discrete properties #62822

Closed
Streq opened this issue Jul 7, 2022 · 3 comments · Fixed by #63119
Closed

AnimationPlayer's RESET track defaults to Continuous for discrete properties #62822

Streq opened this issue Jul 7, 2022 · 3 comments · Fixed by #63119

Comments

@Streq
Copy link
Contributor

Streq commented Jul 7, 2022

Godot version

v3.4.4.stable.official [419e713]

System information

Ubuntu 20.04.3 LTS

Issue description

When a new track is created for a discrete property, like a resource, or a bool, the RESET track for that property is created in continuous mode, which sometimes (couldn't figure out the reproduction conditions) results in said property not resetting when the RESET animation is played (this is fixed by manually setting the track to Discrete).

Steps to reproduce

  • Create a new scene consisting of an AnimationPlayer
  • Create a new animation
  • While the Animation Panel is open click on the keyframe button image for the property Reset On Save (though any boolean property will do)
  • When prompted leave as is and click create
    image
  • Notice the track in the RESET animation is set to Continuous
    image
  • While the track in the actual animation is set to Discrete
    image

Minimal reproduction project

(omitted since it occurs while editing and it can be reproduced using a scene composed of just an AnimationPlayer)

@Calinou
Copy link
Member

Calinou commented Jul 7, 2022

cc @RandomShaper

@KoBeWi
Copy link
Member

KoBeWi commented Jul 8, 2022

Pretty sure the update mode shouldn't affect the property resetting. The track has only one key, so it's irrelevant.

@Streq
Copy link
Contributor Author

Streq commented Jul 8, 2022

@KoBeWi the specific instance where this quirk became, or rather uncovered, a bug involved a shader material property not being reset in the RESET animation until the mode was set to Discrete. I can still reproduce it in my project, but I couldn't isolate the bug, I'll try to come up with a minimal reproduction project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants