AudioStreamRandomPitch doesn't play correct sounds when instanced fast

[jkulawik]

Godot version: 3.3

OS/device including version: Windows 7

Issue description:
When instancing AudioStreamPlayer3D that use AudioStreamRandomPitch as their stream, and then trying to assign different audio streams to the AudioStreamRandomPitch.stream fields, they play the same sound when instanced within the same function call.

I am using set-up similar to the minimal reproduction project one in a bigger project. It never caused any issues when the nodes were instanced in separate function calls. When directly changing the AudioStreamPlayer3D.stream property to an AudioStream, this bug doesn't occur.

Steps to reproduce:
Open the minimal reproduction project and run it. You should hear only one sound, but played twice (sounds a bit like a delay effect).

To see that the instances behave as intended when instanced slowly, do this: In main.gd, comment out one of the instance_audio function calls and restart the program to hear the singular sound. You can do the same with both sounds.

To see that the bug doesn't occur when changing the AudioStreamPlayer3D.stream property directly, uncomment the only commented line in AudioPlayer.gd and comment out the one above it, then restart the program .

Minimal reproduction project:
MinimalReproductionProject.zip

[Calinou]

As a workaround, use an AutoLoad that creates new AudioStreamPlayer nodes with random pitch properties and frees the nodes as needed: https://github.com/Calinou/escape-space/blob/master/autoload/sound.gd

This also allows for polyphony (playing multiple sounds at the same time).

[jkulawik]

Thanks, that's a very elegant workaround so I'll run with it! Honestly I feel silly for not coming up with it myself ;P

PS. Just in case and to be clear, in the example the instanced nodes are freed