Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Tween.stop() to pause() #43442

Closed
opl- opened this issue Nov 10, 2020 · 3 comments
Closed

Rename Tween.stop() to pause() #43442

opl- opened this issue Nov 10, 2020 · 3 comments

Comments

@opl-
Copy link
Contributor

opl- commented Nov 10, 2020

The Tween.stop() and Tween.stop_all() methods are named in a way that suggests that they stop the playback and reset the tween progress to 0, while in reality it only stops playback.

Related:

@Calinou
Copy link
Member

Calinou commented Nov 10, 2020

It would be better to leave a comment in #16863 (comment) for API renaming requests.

That said, keep in mind Tween is being rewritten for 4.0.

@opl-
Copy link
Contributor Author

opl- commented Nov 10, 2020

Yeah, I'm writing a comment in that thread as we speak. Honestly the issue of "stop" vs "pause" is already being discussed in several places, so I decided to open a separate issue to track Tween naming specifically. Feel free to close it in favor of the tracker thread or making #31168 more general.

Edit: Also, thanks for mentioning the Tween rewrite, I was not aware of that. I'll take a look at it and try to link this issue to the PR if relevant.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 19, 2021

The rewrite was merged, so this issue is resolved.

@KoBeWi KoBeWi closed this as completed Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants