Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miter limit should be parameter with default value, not hardcoded. #29886

Open
ghmart opened this issue Jun 19, 2019 · 3 comments
Open

Miter limit should be parameter with default value, not hardcoded. #29886

ghmart opened this issue Jun 19, 2019 · 3 comments

Comments

@ghmart
Copy link

ghmart commented Jun 19, 2019

Godot version:
3.2

Issue description:
When using offset_polygon_2d with JOIN_MITER join type it cuts nesessary geometry sometimes:

ml

On the left is what is needed. On the right is what offsetting polygon gives.

Please, add this! Original library allows miter limit to be set.

@akien-mga
Copy link
Member

I think that's what #29758 does (@Xrayez)

@ghmart
Copy link
Author

ghmart commented Jun 19, 2019

Yes, that's what #29758 does. My apologies. Thought my question on forums were missed and made this issue.

@Xrayez
Copy link
Contributor

Xrayez commented Jun 19, 2019

@ghmart Yeah, no problem, it just makes it more clear what should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants