Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLES2 "Do not Receive Shadows" is not working #27061

Closed
Tobi-La opened this issue Mar 14, 2019 · 6 comments · Fixed by #28723
Closed

GLES2 "Do not Receive Shadows" is not working #27061

Tobi-La opened this issue Mar 14, 2019 · 6 comments · Fixed by #28723

Comments

@Tobi-La
Copy link

Tobi-La commented Mar 14, 2019

Godot version:
3.1 stable

OS/device including version:
Windows 10

Issue description:
The spatial material has an option "Do not Receive Shadows". Shadows are rendered onto this mesh even if this option is checked. It's working as intended on GLES3.

GLES2:
gles2

GLES3:
gles3

Steps to reproduce:

  • Create a new 3D scene
  • add a light source
  • add two meshes, one which is casting a shadow and one which is receiving the shadow
  • check "Do not Receive Shadows" in the options of the spatial material of the receiving mesh

Minimal reproduction project:

ReceiveShadowBug.zip

@clayjohn
Copy link
Member

It looks like the issue is that the "shadows_disabled" render flag hasn't been implemented in scene.glsl in GLES2. https://github.com/godotengine/godot/blob/master/drivers/gles2/shaders/scene.glsl

@SouzaGuilherme
Copy link
Contributor

Hi, I'm going to try to implement this part

@SouzaGuilherme
Copy link
Contributor

looking at both codes really is not implemented SHADOW_DISABLE, I entered IRC and FreeBDS works, I think bug on windows (I'm a novice and novice contributor in the engine too), but in GLES2 the functions are of SHADOW && Light, so I'm analyzing how to implement

@zqyoung1
Copy link

zqyoung1 commented Apr 8, 2019

@SouzaGuilherme Are you still working on this issue? If you are not I'd like to pick it up.

@SouzaGuilherme
Copy link
Contributor

Yes, I'm still working on that. I'm having a bad time since I have little shaders knowledge, but i think that 4 days are enough.

@SouzaGuilherme
Copy link
Contributor

Giving news on the issue, I confirm issue # 28171 is related to the current issue. I'm having a bit of trouble, so the delay, any help is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants