Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis is missing the IDENTITY and ortho constants #26682

Closed
aaronfranke opened this issue Mar 6, 2019 · 3 comments · Fixed by #31228
Closed

Basis is missing the IDENTITY and ortho constants #26682

aaronfranke opened this issue Mar 6, 2019 · 3 comments · Fixed by #31228

Comments

@aaronfranke
Copy link
Member

aaronfranke commented Mar 6, 2019

Godot version: 3.1 beta 10

OS/device including version: All

Issue description:

While Vector3 has constants such as ONE and UP, Basis is missing the IDENTITY constant and the otho constants. These constants are already present in C# here, but not in GDScript. Related PR: #14704

I will fix this later if nobody else does, but it will have to wait for 3.2. It's very non-critical.

@neikeq
Copy link
Contributor

neikeq commented Mar 6, 2019

Isn't Basis() the same as Identity?

@aaronfranke
Copy link
Member Author

@neikeq Yes, you're right, it is! Though, there should still be an IDENTITY property to avoid confusion, just as Vector3 has ZERO. Also, I noticed that in C#, there is no parameterless Basis constructor.

@neikeq
Copy link
Contributor

neikeq commented Mar 6, 2019

C# doesn't allow value types to have parameterless constructors (I think CLR does allow it though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants