Optimize Node.find_children

Author: Joy-less

scene/main/node.cpp

@@ -2008,34 +2008,38 @@ TypedArray<Node> Node::find_children(const String &p_pattern, const String &p_ty
 	TypedArray<Node> ret;
 	ERR_FAIL_COND_V(p_pattern.is_empty() && p_type.is_empty(), ret);
 	_update_children_cache();
-	Node *const *cptr = data.children_cache.ptr();
-	int ccount = data.children_cache.size();
-	for (int i = 0; i < ccount; i++) {
-		if (p_owned && !cptr[i]->data.owner) {
-			continue;
-		}
 
-		if (p_pattern.is_empty() || cptr[i]->data.name.operator String().match(p_pattern)) {
-			if (p_type.is_empty() || cptr[i]->is_class(p_type)) {
-				ret.append(cptr[i]);
-			} else if (cptr[i]->get_script_instance()) {
-				Ref<Script> scr = cptr[i]->get_script_instance()->get_script();
-				while (scr.is_valid()) {
-					if ((ScriptServer::is_global_class(p_type) && ScriptServer::get_global_class_path(p_type) == scr->get_path()) || p_type == scr->get_path()) {
-						ret.append(cptr[i]);
-						break;
-					}
+	const auto find_children_add = [&](const auto &find_children_add, TypedArray<Node> &p_array, const Node* p_current_node) -> void {
+		Node *const *cptr = p_current_node->data.children_cache.ptr();
+		int ccount = p_current_node->data.children_cache.size();
+		for (int i = 0; i < ccount; i++) {
+			if (p_owned && !cptr[i]->data.owner) {
+				continue;
+			}
+
+			if (p_pattern.is_empty() || cptr[i]->data.name.operator String().match(p_pattern)) {
+				if (p_type.is_empty() || cptr[i]->is_class(p_type)) {
+					p_array.append(cptr[i]);
+				} else if (cptr[i]->get_script_instance()) {
+					Ref<Script> scr = cptr[i]->get_script_instance()->get_script();
+					while (scr.is_valid()) {
+						if ((ScriptServer::is_global_class(p_type) && ScriptServer::get_global_class_path(p_type) == scr->get_path()) || p_type == scr->get_path()) {
+							p_array.append(cptr[i]);
+							break;
+						}
 
-					scr = scr->get_base_script();
+						scr = scr->get_base_script();
+					}
 				}
 			}
-		}
 
-		if (p_recursive) {
-			ret.append_array(cptr[i]->find_children(p_pattern, p_type, true, p_owned));
+			if (p_recursive) {
+				find_children_add(find_children_add, p_array, cptr[i]);
+			}
 		}
-	}
+	};
 
+	find_children_add(find_children_add, ret, this);
 	return ret;
 }