Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration files? #6

Open
LikeLakers2 opened this issue Dec 3, 2018 · 4 comments
Open

Configuration files? #6

LikeLakers2 opened this issue Dec 3, 2018 · 4 comments

Comments

@LikeLakers2
Copy link

/benchmarks/README.md and /tests/README.md both mention that configuration files of some sort should be included. However, no example configuration is given, nor is the format documented that these configuration files would need to be in.

Has that format been decided before? If so, it should be documented in those README files. Otherwise, I hope this issue could spark some discussion on what format the configs should use.

@Calinou
Copy link
Member

Calinou commented Dec 3, 2018

Otherwise, I hope this issue could spark some discussion on what format the configs should use.

Would the ConfigFile class work for this?

@LikeLakers2
Copy link
Author

LikeLakers2 commented Dec 3, 2018

Would the ConfigFile class work for this?

Of course, but I was meaning what kind of data (name? brief description? etc.) these configuration files would need to have, not what the file type should be. My apologies for not clarifying.

@fire
Copy link
Member

fire commented Nov 17, 2020

Anything that is actionable two years later?

@LikeLakers2
Copy link
Author

LikeLakers2 commented Nov 17, 2020

I would think so. As mentioned in the original comment, the README files don't really explain what these "Configuration files" are, or how they're formatted, or what they're supposed to be. While it seems now that both take in Godot projects, it should be clarified since "Configuration file" could still mean any number of things (project settings? a python script? etc.).

We should either clarify that, or we should remove the two README files and explain this in the root of the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants