Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove current export template version from "Installed Versions" list in Export Template Manager #2394

Closed
wingedadventurer opened this issue Mar 3, 2021 · 2 comments · Fixed by godotengine/godot#46952
Milestone

Comments

@wingedadventurer
Copy link

wingedadventurer commented Mar 3, 2021

Describe the project you are working on

N/A (not project related).

Describe the problem or limitation you are having in your project

In the "Export Template Manager" popup, current version is listed twice if installed: at the top under Current Version label, and below under Installed Versions label:

v1

I propose to remove it from bottom list because:

  1. unnecessary duplication (you can already see that it's installed due to "(Installed)" suffix in its name, and due to the button next to it saying "Uninstall"
  2. possibly very specific and personal case, but one might want to uninstall all previous export templates by just clicking all "Uninstall" buttons, and accidentally uninstall current one since it's in the bottom list and didn't expect it to be there.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Just remove current export template from the "Installed Versions" list, like so:

v2

Additionally, rename "Installed Versions" to "Other Installed Versions" to make it less misleading.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I'm assuming it's fairly trivial to make the item not appear in the list below.

If this enhancement will not be used often, can it be worked around with a few lines of script?

N/A

Is there a reason why this should be core and not an add-on in the asset library?

N/A

@YuriSizov
Copy link
Contributor

Additionally, rename "Installed Versions" to "Other Installed Versions" to make it misleading.

Hopefully, to make it less misleading, though 🙃

@wingedadventurer
Copy link
Author

Oops! Good catch, corrected it. :D

AaronRecord added a commit to AaronRecord/godot that referenced this issue Mar 18, 2021
**Not tested** (I don't have an easy way to test currently). Resolves godotengine/godot-proposals#2394 .
@akien-mga akien-mga added this to the 4.0 milestone Apr 24, 2021
akien-mga pushed a commit to akien-mga/godot that referenced this issue Apr 26, 2021
**Not tested** (I don't have an easy way to test currently). Resolves godotengine/godot-proposals#2394 .

(cherry picked from commit c562c69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants